Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct spelling #4250

Merged
merged 5 commits into from
May 4, 2021
Merged

Correct spelling #4250

merged 5 commits into from
May 4, 2021

Conversation

az0
Copy link
Contributor

@az0 az0 commented May 3, 2021

Most changes were in comments, and there were a few changes to literals for log output.

There were no changes to variable names, function names, IDs, or functionality.

@az0
Correct spelling
7e6d638 
Most changes were in comments, and there were a few changes to literals for log output.

There were no changes to variable names, function names, IDs, or functionality.
jameslamb
jameslamb requested changes May 3, 2021
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for taking the time to contribute to LightGBM.

I've left a few small suggested changes. You can accept them directly in the browser by clicking "commit suggestion".

src/treelearner/feature_histogram.hpp Outdated Show resolved Hide resolved
src/treelearner/feature_histogram.hpp Outdated Show resolved Hide resolved
src/treelearner/feature_histogram.hpp Outdated Show resolved Hide resolved
src/treelearner/gpu_tree_learner.cpp Show resolved Hide resolved
az0 and others added 3 commits May 3, 2021 16:07
@az0 @jameslamb
Clarify a phrase in a comment
7702a15 
Co-authored-by: James Lamb <jaylamb20@gmail.com>
@az0 @jameslamb
Clarify a phrase in a comment
678a263 
Co-authored-by: James Lamb <jaylamb20@gmail.com>
@az0 @jameslamb
Clarify a phrase in a comment
4b789f0 
Co-authored-by: James Lamb <jaylamb20@gmail.com>
@StrikerRUS
Copy link
Collaborator

Hmmm... Something new.

image

@jameslamb
Copy link
Collaborator

Hmmm... Something new.

image

that is because of abuse by crypto miners: https://www.bleepingcomputer.com/news/security/github-actions-being-actively-abused-to-mine-cryptocurrency-on-github-servers/

@StrikerRUS
Copy link
Collaborator

that is because of abuse by crypto miners

Ah, I see! Good protection. I remember I saw 2 attacking PRs in my another repo several weeks ago.

I'm clicking "Approve and run".

@az0
Correct spelling
e4394cd 
Most are code comments, but one case is a literal in a logging message.

There are a few grammar fixes too.
jameslamb
jameslamb approved these changes May 4, 2021
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks very much!

@jameslamb jameslamb merged commit e79716e into microsoft:master May 4, 2021
@jameslamb
Copy link
Collaborator

Thanks very much @az0 ! Come back and contribute any time 😀

@az0
Copy link
Contributor Author

az0 commented May 4, 2021

Thanks very much @az0 ! Come back and contribute any time 😀

@jameslamb

You're welcome. Thank you for making it easy and quick.

@StrikerRUS StrikerRUS mentioned this pull request May 4, 2021
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@btrotta btrotta Awaiting requested review from btrotta

@chivee chivee Awaiting requested review from chivee

@guolinke guolinke Awaiting requested review from guolinke guolinke is a code owner

@henry0312 henry0312 Awaiting requested review from henry0312

@huanzhang12 huanzhang12 Awaiting requested review from huanzhang12

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

@StrikerRUS StrikerRUS Awaiting requested review from StrikerRUS StrikerRUS is a code owner

@wxchan wxchan Awaiting requested review from wxchan

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@az0 @StrikerRUS @jameslamb